Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update audio.py #12

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Update audio.py #12

wants to merge 3 commits into from

Conversation

anupammaurya6767
Copy link

Changes Made

  • Consistent Naming Convention
  • Combined Similar Functions
  • Use of NumPy/PyTorch Functions
  • In-Place Operations
  • Removed Unused Imports

@rasenganai
Copy link
Collaborator

Thanks @anupammaurya6767 for refactoring the code, I can see you have removed the comments and combined two functions together.
the combined function normalize_and_denormalize_tacotron_mel is being used in other files, hence it will fail.

Try correcting this, and add the comments back

@anupammaurya6767
Copy link
Author

@rasenganai updated the code
added comments back and also separated the normalize_and_denormalize_tacotron_mel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anupammaurya6767 @rasenganai